Core: Add test for renaming table to a non-existing namespace #9895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
commented
Mar 7, 2024
| @@ -226,6 +226,12 @@ public void renameTable(TableIdentifier from, TableIdentifier originalTo) { | |||
| throw new NoSuchTableException("Invalid identifier: %s", from); | |||
| } | |||
|
|
|||
| if (!namespaceExists(originalTo.namespace())) { | |||
There was a problem hiding this comment.
While reviewing #9852 I noticed that there's no such check in Hive that checks whether that namespace exists and Hive would just fail with a RuntimeException
nastra
force-pushed
the
test-for-missing-target-namespace-on-table-rename
branch
from
a5980ca to
3142109
Compare
nastra
force-pushed
the
test-for-missing-target-namespace-on-table-rename
branch
from
3142109 to
1b91b10
Compare
amogh-jahagirdar
approved these changes
Mar 8, 2024
nastra
commented
Mar 8, 2024
| @@ -228,6 +228,10 @@ public void renameTable(TableIdentifier from, TableIdentifier originalTo) { | |||
|
|
|||
| TableIdentifier to = removeCatalogName(originalTo); | |||
| Preconditions.checkArgument(isValidIdentifier(to), "Invalid identifier: %s", to); | |||
| if (!namespaceExists(to.namespace())) { | |||
There was a problem hiding this comment.
@pvary could you review this small change please?
pvary
approved these changes
Mar 8, 2024
|
thanks everyone for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For view catalogs we already test the same behavior in https://github.com/apache/iceberg/blob/main/core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java#L589-L611 but we haven't done so for table catalogs.