Core: remove statistic files in CatalogUtil:dropTableData #9305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dramaticlly
force-pushed
the
dropStats
branch
from
2954950
to
886e730
Compare
ajantha-bhat
approved these changes
Dec 15, 2023
core/src/test/java/org/apache/iceberg/hadoop/TestCatalogUtilDropTable.java
Outdated
Show resolved
Hide resolved
|
There is also a partition stats file added recently 6e21bbf We should handle this for them aswell. I can have a follow up PR, if it is too much to handle in this PR. |
| @@ -181,4 +205,34 @@ private Set<String> metadataLocations(TableMetadata tableMetadata) { | |||
| metadataLocations.add(tableMetadata.metadataFileLocation()); | |||
| return metadataLocations; | |||
| } | |||
|
|
|||
| private Set<String> statsLocations(TableMetadata tableMetadata) { | |||
There was a problem hiding this comment.
nit: these two new private methods can be static
amogh-jahagirdar
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
This change looks good @dramaticlly , thanks for the fix! Thanks @ajantha-bhat @RussellSpitzer for the reviews. I'll go ahead and merge this.
I will open the follow up PR for partition stats files today. |
lisirrx
pushed a commit
to lisirrx/iceberg
that referenced
this pull request
Jan 4, 2024
Co-authored-by: Steve Zhang <hongyue_zhang@apple.com>
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
Co-authored-by: Steve Zhang <hongyue_zhang@apple.com>
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Co-authored-by: Steve Zhang <hongyue_zhang@apple.com>
1 task
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempt to include puffin stats files as part of CatalogUtil table cleanup
CC @RussellSpitzer @findepi