GCS: Allow no-auth for testing purposes #9061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XN137
reviewed
Nov 14, 2023
nastra
reviewed
Nov 14, 2023
nastra
reviewed
Nov 14, 2023
nastra
reviewed
Nov 14, 2023
nastra
reviewed
Nov 14, 2023
dimas-b
approved these changes
Nov 14, 2023
dimas-b
approved these changes
Nov 14, 2023
nastra
reviewed
Nov 15, 2023
| String.format( | ||
| "Invalid auth settings: must not configure %s and %s", | ||
| GCS_NO_AUTH, GCS_OAUTH2_TOKEN)); | ||
| Assertions.assertThatNoException() |
There was a problem hiding this comment.
rather than just checking that no exception has been thrown, I think the better alternative would be:
GCPProperties gcpProperties =
new GCPProperties(ImmutableMap.of(GCS_OAUTH2_TOKEN, "oauth", GCS_NO_AUTH, "false"));
assertThat(gcpProperties.noAuth()).isFalse();
assertThat(gcpProperties.oauth2Token()).isPresent().get().isEqualTo("oauth");
gcpProperties = new GCPProperties(ImmutableMap.of(GCS_NO_AUTH, "true"));
assertThat(gcpProperties.noAuth()).isTrue();
assertThat(gcpProperties.oauth2Token()).isNotPresent();
|
@bryanck could you review this one please? |
|
This looks good to me, as long as the format checks are passing. |
bryanck
approved these changes
Nov 16, 2023
Although there is no "official" Google Cloud Storage emulator available yet, there is [one available](https://github.com/oittaa/gcp-storage-emulator) that allows at least some basic testing. To use an emulator, the client needs to be configured to use no authentication, otherwise it will fallback to "automatic credential detection".
nastra
approved these changes
Nov 17, 2023
1 task
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Although there is no "official" Google Cloud Storage emulator available yet, there is [one available](https://github.com/oittaa/gcp-storage-emulator) that allows at least some basic testing. To use an emulator, the client needs to be configured to use no authentication, otherwise it will fallback to "automatic credential detection".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although there is no "official" Google Cloud Storage emulator available yet, there is one available that allows at least some basic testing. To use an emulator, the client needs to be configured to use no authentication, otherwise it will fallback to "automatic credential detection".