Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API, Core: implement types timestamp_ns and timestamptz_ns #8971

Closed
wants to merge 9 commits into from
Closed

API, Core: implement types timestamp_ns and timestamptz_ns #8971

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3c77542
API: implement types timestamp_ns and timestamptz_ns
jacobmarble Sep 26, 2023
5fd82c2
Core: add types timestamp_ns and timestamptz_ns
jacobmarble Sep 28, 2023
24e6143
chore: update ORC and Parquet
jacobmarble Nov 3, 2023
3b87435
chore: cast timestamp and get unit once
jacobmarble Nov 3, 2023
74b90d9
chore: clean up switch/default/if/else logic
jacobmarble Nov 3, 2023
5278960
chore: cleanup exceptions thrown for timestamp unit
jacobmarble Nov 3, 2023
77bd16d
chore: deprecate TimestampType.with[out]Zone()
jacobmarble Nov 3, 2023
c910484
fix: interpret timestamp strings as micros or nanos
jacobmarble Nov 6, 2023
cb109a4
cleanup: revert unrelated change
jacobmarble Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
cleanup: revert unrelated change 
Resolves:
- https://github.com/apache/iceberg/pull/8971/files/24e61436f3d6f696b4ddce80b75523a5db90fb5c?show-viewed-files=true&file-filters%5B%5D=#r1381238654
  • Loading branch information
@jacobmarble
jacobmarble committed Nov 7, 2023
commit cb109a47857c58ae5e5d31f7ef2d2b01bf8180a0
19 changes: 15 additions & 4 deletions api/src/main/java/org/apache/iceberg/transforms/PartitionSpecVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,24 @@ static <R> R visit(Schema schema, PartitionField field, PartitionSpecVisitor<R>
} else if (transform instanceof Truncate) {
int width = ((Truncate<?>) transform).width();
return visitor.truncate(field.fieldId(), sourceName, field.sourceId(), width);
} else if ("year".equalsIgnoreCase(transform.toString())) {
} else if (transform == Dates.YEAR
|| transform == Timestamps.YEAR_FROM_MICROS
|| transform == Timestamps.YEAR_FROM_NANOS
|| transform instanceof Years) {
return visitor.year(field.fieldId(), sourceName, field.sourceId());
} else if ("month".equalsIgnoreCase(transform.toString())) {
} else if (transform == Dates.MONTH
|| transform == Timestamps.MONTH_FROM_MICROS
|| transform == Timestamps.MONTH_FROM_NANOS
|| transform instanceof Months) {
return visitor.month(field.fieldId(), sourceName, field.sourceId());
} else if ("day".equalsIgnoreCase(transform.toString())) {
} else if (transform == Dates.DAY
|| transform == Timestamps.DAY_FROM_MICROS
|| transform == Timestamps.DAY_FROM_NANOS
|| transform instanceof Days) {
return visitor.day(field.fieldId(), sourceName, field.sourceId());
} else if ("hour".equalsIgnoreCase(transform.toString())) {
} else if (transform == Timestamps.HOUR_FROM_MICROS
|| transform == Timestamps.HOUR_FROM_NANOS
|| transform instanceof Hours) {
return visitor.hour(field.fieldId(), sourceName, field.sourceId());
} else if (transform instanceof VoidTransform) {
return visitor.alwaysNull(field.fieldId(), sourceName, field.sourceId());
Expand Down