Nessie: Fix possible table-metadata loss #8413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -153,13 +153,12 @@ protected void doCommit(TableMetadata base, TableMetadata metadata) { | |||
| // to catch all kinds of network errors (e.g. connection reset). Network code implementation | |||
| // details and all kinds of network devices can induce unexpected behavior. So better be | |||
| // safe than sorry. | |||
| delete = false; | |||
| throw new CommitStateUnknownException(ex); | |||
| } catch (NessieNotFoundException ex) { | |||
| throw new RuntimeException( | |||
There was a problem hiding this comment.
we can delete in this case also right? As it is definitely a failure to commit?
`NessieTableOperations.doCommit()` wrongly assumes that _every_ exception thrown during a Nessie commit operation is a failure that requires the deletion of the newly written table-metadata. However, for exceptions like `j.l.InterruptedException` or HTTP timeout/error it is unclear whether the Nessie commit went through (or will go through), so deleting the table-metadata is wrong here. This change updates the logic to only delete the table-metadata file if a `NessieReferenceConflictException` happened, when it is clear that the commit really failed.
ajantha-bhat
approved these changes
Aug 29, 2023
dimas-b
approved these changes
Aug 29, 2023
nastra
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NessieTableOperations.doCommit()wrongly assumes that every exception thrown during a Nessie commit operation is a failure that requires the deletion of the newly written table-metadata. However, for exceptions likej.l.InterruptedExceptionor HTTP timeout/error it is unclear whether the Nessie commit went through (or will go through), so deleting the table-metadata is wrong here.This change updates the logic to only delete the table-metadata file if a
NessieReferenceConflictExceptionhappened, when it is clear that the commit really failed.