GCP: Add range reads to GCSInputStream #8301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanck
commented
Aug 12, 2023
| @@ -49,7 +49,7 @@ public void testMissingScheme() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void tesInvalidScheme() { | |||
| public void testInvalidScheme() { | |||
bryanck
commented
Aug 12, 2023
| @@ -67,6 +67,7 @@ public class GCPProperties implements Serializable { | |||
|
|
|||
| public GCPProperties() {} | |||
|
|
|||
| @SuppressWarnings("JavaUtilDate") // GCP API uses java.util.Date | |||
There was a problem hiding this comment.
GCP uses java.util.Date in its API so suppressed this warning
nastra
approved these changes
Aug 14, 2023
|
LGTM, thanks @bryanck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds range reads to GCSInputStream and implements the RangeReadable interface. The range read tests were derived from those for S3InputStream. With S3, a range can be specified as the number of bytes from end, but a similar API is not available with GCS, so the implementation for reading the tail calculates the starting position based on the blob size.