Python: Small fixes

[Fokko]

Uncovered these when upgrading to Pydantic 2.0

[JonasJ-ap]

LGTM! @Fokko Thanks for your great work!

One minor non-blocking suggestion: I think it would be great to update snapshot_id parameter in these tests to use int type, to reflect the improvements made in the PR.

iceberg/python/tests/table/test_init.py

Lines 185 to 189 in 1f1ec4b

	def test_history(table: Table) -> None:
	assert table.history() == [
	SnapshotLogEntry(snapshot_id="3051729675574597004", timestamp_ms=1515100955770),
	SnapshotLogEntry(snapshot_id="3055729675574597004", timestamp_ms=1555100955770),
	]

iceberg/python/tests/catalog/test_hive.py

Lines 353 to 356 in 1f1ec4b

	snapshot_log=[
	SnapshotLogEntry(snapshot_id="3051729675574597004", timestamp_ms=1515100955770),
	SnapshotLogEntry(snapshot_id="3055729675574597004", timestamp_ms=1555100955770),
	],

[Fokko]

@JonasJ-ap Great catch!

[GadiZimerman]

@CodiumAI-Agent

[CodiumAI-Agent]

PR Analysis

• 🎯 Main theme: Refactoring the code to improve type annotations and default values
• 🔍 Description and title: Yes
• 📌 Type of PR: Refactoring
• 🧪 Relevant tests added: No
• ✨ Minimal and focused: Yes, the PR is minimal and focused as it only deals with improving type annotations and default values in the code
• 🔒 Security concerns: No, the PR does not introduce any apparent security concerns as it mainly deals with type annotations and default values

PR Feedback

• 💡 General PR suggestions: The PR is well-structured and follows good practices. However, it would be beneficial to add tests to ensure that the changes do not introduce any regressions.

• 🤖 Code suggestions:

  • relevant file: python/pyiceberg/table/init.py
    suggestion content: Consider adding docstrings to the classes and methods to improve code readability and maintainability. [medium]

  • relevant file: python/pyiceberg/table/metadata.py
    suggestion content: Consider using a constant for the default value of 'last_partition_id' instead of 'None' to improve code readability. [medium]

  • relevant file: python/pyiceberg/table/snapshots.py
    suggestion content: Consider adding error handling or checks for the 'snapshot_id' field as it is a critical field. [important]

  • relevant file: python/tests/catalog/test_hive.py
    suggestion content: Consider adding assertions to check the values of the fields in the 'SnapshotLogEntry' objects to ensure they are as expected. [medium]

How to use

Tag me in a comment '@CodiumAI-Agent' to ask for a new review after you update the PR.
You can also tag me and ask any question, for example '@CodiumAI-Agent is the PR ready for merge?'

[nastra]

LGTM, thanks @Fokko. And thanks @JonasJ-ap for reviewing