Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCP, Pig: Switch tests to JUnit5 #7647

Merged
merged 7 commits into from
May 19, 2023
Merged

GCP, Pig: Switch tests to JUnit5 #7647

merged 7 commits into from
May 19, 2023

Conversation

rakesh-das08
Copy link
Contributor

In line with #7160
Modules changed:

  1. iceberg-gcp
  2. iceberg-pig

@rakesh-das08
Copy link
Contributor Author

@nastra please check

@rakesh-das08 rakesh-das08 changed the title Upgrading tests to junit5 Core: Upgrading tests to junit5 May 18, 2023
@rakesh-das08 rakesh-das08 changed the title Core: Upgrading tests to junit5 Core: Upgrading tests to junit5 (GCP, Pig) May 18, 2023
nastra
nastra reviewed May 19, 2023
View reviewed changes
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes themselves LGTM but you need to enable JUnit5 for the iceberg-gcp and iceberg-pig module via

test {
    useJUnitPlatform()
  }

in gradle.properties (similar to how it's done for the other gradle modules).

@nastra nastra changed the title Core: Upgrading tests to junit5 (GCP, Pig) GCP, Pig: Switch tests to JUnit5 May 19, 2023
@github-actions github-actions bot added the build label May 19, 2023
nastra
nastra approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when CI passes

@nastra nastra merged commit d3fcd98 into apache:master May 19, 2023
@rakesh-das08 rakesh-das08 deleted the junit5_upgrade branch May 19, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastra nastra nastra approved these changes

Assignees
No one assigned
Labels
build GCP pig
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakesh-das08 @nastra