Spark: Fix failing SS UT #7414
Merged
Spark: Fix failing SS UT #7414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackye1995
approved these changes
Apr 23, 2023
|
Thanks for the quick fix! Will merge asap after CI passes to unblock other people |
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Co-authored-by: Prashant Singh <psinghvk@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the change
As part of implementing
SupportsAdmissionControlwe now implementOffset latestOffset(Offset startOffset, ReadLimit limit);it faces the same problem as here #6480 , this change now throws an IllegalStateException instead of NPE and the ci for rate-limit pr had not run been rebased and re-run this couldn't be caught.This pr attempts to fix the issue by having the similar handling.
Testing
failing ut's pass now
cc @jackye1995