API: Binder should not simplify isNull and notNull when their reference … #7346
Conversation
|
|
||
| checkOnlyIcebergFilters( | ||
| "point.x IS NULL" /* query predicate */, | ||
| "point.x IS NULL" /* Iceberg scan filters */, |
There was a problem hiding this comment.
This query returns no rows without this PR.
|
Seems like a good catch. I'll try to review the actual fix later this week unless someone gets there earlier. cc @nastra @rdblue @szehon-ho @flyrain @amogh-jahagirdar @jackye1995 |
|
Hey @aokolnychyi , do you have time to review this? |
…fields are required but nested in optional parents.
zhongyujiang
force-pushed
the
fix-binder-simplifiction
branch
from
527a203 to
e6989ae
Compare
zhongyujiang
changed the title
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
…fields are required but nested in optional parents.
Currently,
Binderwill simpifyisNullandnotNulltoalwaysFalseandalwaysTruerespectively, when the expressions are to be bound to required fields. However a required field can still be null in the row when it is nested in an optional parent field. Therefore, this causes data to be incorrectly skipped when querying for rows where their nested field(required sub field nested in optional parent) is null.This changes the
Binderto only simplify nullability predicates when their target field and all its parents are all required, to fix this issue.