Core: Fix errorprone warning #7286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @Fokko |
nastra
reviewed
Apr 6, 2023
| @@ -75,7 +75,7 @@ private static class InMemorySeekableInputStream extends SeekableInputStream { | |||
| @Override | |||
| public long getPos() throws IOException { | |||
| checkOpen(); | |||
| return length - delegate.available(); | |||
| return (long) length - delegate.available(); | |||
There was a problem hiding this comment.
I would rather make length a long a few lines above
nastra
approved these changes
Apr 10, 2023
Fokko
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Thanks again for fixing this @ajantha-bhat, thanks @nastra for the review
ericlgoodman
pushed a commit
to ericlgoodman/iceberg
that referenced
this pull request
Apr 12, 2023
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping the build clean [
./gradlew clean build -x test -x integrationTest]