AWS: Check commit status after failed commit if AWS client performed retries #7198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed this doesn't break the existing integration tests. Going to add some additional ones to better replicate the scenario this is designed to fix. |
jackye1995
reviewed
Mar 28, 2023
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Mar 28, 2023
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Mar 28, 2023
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Mar 28, 2023
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbTableOperations.java
Outdated
Show resolved
Hide resolved
ChristinaTech
commented
Mar 29, 2023
JonasJ-ap
reviewed
Mar 30, 2023
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogCommitFailure.java
Show resolved
Hide resolved
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogCommitFailure.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This is great @ChristinaTech ! Left some comments/questions, thanks for the contribution!
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java
Outdated
Show resolved
Hide resolved
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbTableOperations.java
Outdated
Show resolved
Hide resolved
aws/src/main/java/org/apache/iceberg/aws/glue/GlueTableOperations.java
Outdated
Show resolved
Hide resolved
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbTableOperations.java
Outdated
Show resolved
Hide resolved
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbTableOperations.java
Show resolved
Hide resolved
jackye1995
approved these changes
Apr 10, 2023
amogh-jahagirdar
approved these changes
Apr 10, 2023
|
Thanks for the work @ChristinaTech ! Thanks for the reviews @amogh-jahagirdar @JonasJ-ap ! |
|
Thanks @ChristinaTech. @jackye1995 @amogh-jahagirdar @JonasJ-ap Could you please include this fix in the next release? |
ericlgoodman
pushed a commit
to ericlgoodman/iceberg
that referenced
this pull request
Apr 12, 2023
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described by #7151 where a commit can succeed but Glue or Dynamo backed tables see a failure and delete the now-committed metadata.