Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: Use Apache HTTP client as default AWS HTTP client #7119

Merged
merged 3 commits into from
Mar 16, 2023
Merged

AWS: Use Apache HTTP client as default AWS HTTP client #7119

merged 3 commits into from
Mar 16, 2023

Conversation

singhpk234
Copy link
Contributor

@singhpk234 singhpk234 commented Mar 15, 2023 •
edited by jackye1995
Loading

Fixes #7118

@jackye1995
Copy link
Contributor

Does integration tests still pass?

@singhpk234 singhpk234 force-pushed the enhancement/http-client branch from 5bc86e4 to 9f2f06b Compare March 15, 2023 22:30
JonasJ-ap
JonasJ-ap reviewed Mar 16, 2023
View reviewed changes
Copy link
Contributor

@JonasJ-ap JonasJ-ap left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change!

@singhpk234 singhpk234 force-pushed the enhancement/http-client branch 2 times, most recently from 10f361f to 83a3514 Compare March 16, 2023 02:11
@singhpk234 singhpk234 force-pushed the enhancement/http-client branch from 83a3514 to c79c1e3 Compare March 16, 2023 02:20
jackye1995
jackye1995 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to overall refactor a bit of the AWS doc, but that can be done in another PR, this looks good to me.

Also in the next release including this, we need to mention the dependency change in release note, in case people just include the minimum number of AWS jars and only have dependency of url-connection-client.

@jackye1995
Copy link
Contributor

jackye1995 commented Mar 16, 2023 •
edited
Loading

@nastra @danielcweeks could you check if you have any concern of updating this default dependency?

Fokko
Fokko approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less dependencies is more :)

@jackye1995
Copy link
Contributor

Thanks everyone for the review! And thanks @singhpk234 for the quick fix!

@jackye1995 jackye1995 merged commit 053028c into apache:master Mar 16, 2023
@bryanck bryanck mentioned this pull request Apr 2, 2023
Merged
@HonahX HonahX mentioned this pull request Aug 26, 2023
Merged
@nastra nastra mentioned this pull request Sep 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasJ-ap JonasJ-ap JonasJ-ap left review comments

@nastra nastra nastra approved these changes

@Fokko Fokko Fokko approved these changes

@danielcweeks danielcweeks danielcweeks approved these changes

@bryanck bryanck bryanck approved these changes

@jackye1995 jackye1995 jackye1995 approved these changes

Assignees
No one assigned
Labels
AWS docs python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Apache HTTP client as default AWS HTTP client
7 participants
@singhpk234 @jackye1995 @nastra @Fokko @danielcweeks @bryanck @JonasJ-ap