Core: Create commit groups in commit service offer in RewriteDataFilesCommitManager #6539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhpk234
force-pushed
the
opt/rewrite-grp-creation-in-offer
branch
from
4c373c1
to
8ea8bb8
Compare
singhpk234
changed the title
singhpk234
force-pushed
the
opt/rewrite-grp-creation-in-offer
branch
from
8ea8bb8
to
5476e70
Compare
|
Is there any new test case we can add to ensure correctness of this? |
|
Sure @jackye1995, presently I didn't add new ut's to this pr as the ut i was thinking of adding :
|
| @@ -264,5 +253,35 @@ public void close() { | |||
| "File groups offered after service was closed, " | |||
| + "they were not successfully committed."); | |||
| } | |||
|
|
|||
| private void commitReadyCommitGroups() { | |||
| if (canCreateCommitGroup()) { | |||
There was a problem hiding this comment.
I think this is a good way to do things, I was considering having some kind of atomic countdown but I like this as well
core/src/main/java/org/apache/iceberg/actions/RewriteDataFilesCommitManager.java
Show resolved
Hide resolved
RussellSpitzer
requested changes
Jan 12, 2023
singhpk234
force-pushed
the
opt/rewrite-grp-creation-in-offer
branch
from
8476fa7
to
30d48d5
Compare
|
Thanks @singhpk234 for the code, and @jackye1995 for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the change
Implements the idea proposed in #6367
Testing done
Existing UT's
cc @RussellSpitzer @flyrain