Flink: Add support for Flink 1.16 #6092
Conversation
| () -> sql(sqlParseErrorLTE)); | ||
| @Test | ||
| public void testSqlParseNaN() { | ||
| // todo add some test case to test NaN |
There was a problem hiding this comment.
TODO: After the introduction of 1.16, we need to adapt NaN.
From my preliminary tests, we need to make some changes to the filter part of the flink connector.
There was a problem hiding this comment.
do you plan to fix it in this PR or will do it in a follow-up PR?
There was a problem hiding this comment.
I plan to do it in a follow-up PR, which is already in development. 😄
.github/workflows/flink-ci.yml
Outdated
| @@ -93,7 +93,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| jvm: [8, 11] | |||
| flink: ['1.13', '1.14', '1.15'] | |||
| flink: ['1.13', '1.14', '1.15', '1.16'] | |||
There was a problem hiding this comment.
can you create a PR to remove 1.13? I think we typically remove the old version first before merging a new version.
There was a problem hiding this comment.
merged. please rebase this PR
@hililiwei you meant using the |
Yeah, that's what I mean. |
There was a problem hiding this comment.
LGTM
@hililiwei since we are going to use rebase and merge, can you update the commit messages so that each contains the Flink: prefix.
Done. |
|
thanks @hililiwei for the contribution |
To keep git history, please don't squash