AWS: Add socket connection timeout for UrlConnectionHttpClient #5900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasJ-ap
force-pushed
the
add_socket_connection_timeout_urlHttpClient
branch
from
7ce9135 to
40d4a2a
Compare
Fokko
approved these changes
Oct 3, 2022
|
Thank you very much for your reviews! @rajarshisarkar @singhpk234 @amogh-jahagirdar May I ask if there is anything else you want to comment on this change? Thank you in advance. |
singhpk234
approved these changes
Oct 3, 2022
JonasJ-ap
force-pushed
the
add_socket_connection_timeout_urlHttpClient
branch
from
174760b to
8556a0c
Compare
|
Looks like we get a few approvals, thanks @JonasJ-ap for the contribution and thanks @Fokko and @singhpk234 for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can use
http-client.urlconnection.socket-timeout-msandhttp-client.urlconnection.connection-timeout-mstags to configure the connection and socket timeout for theUrlConnectionHttpClient.Add unit test to check the timeout setting.