API,Core: Add scan planning metrics for scanned/skipped delete manifests #5792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
scanned-and-skipped-delete-manifest-metrics
branch
from
adba699 to
7810f91
Compare
amogh-jahagirdar
approved these changes
Sep 19, 2022
core/src/test/java/org/apache/iceberg/TestScanPlanningAndReporting.java
Outdated
Show resolved
Hide resolved
gaborkaszab
reviewed
Sep 20, 2022
core/src/test/java/org/apache/iceberg/metrics/TestScanMetricsResultParser.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
scanned-and-skipped-delete-manifest-metrics
branch
6 times, most recently
from
3c2411d to
6de5ac8
Compare
nastra
force-pushed
the
scanned-and-skipped-delete-manifest-metrics
branch
from
6de5ac8 to
e389a01
Compare
|
LGTM. Looks way better with these Immutable metrics classes. |
rdblue
reviewed
Sep 29, 2022
| @@ -226,6 +236,16 @@ public Counter skippedDeleteFiles() { | |||
| return metricsContext().counter(SKIPPED_DELETE_FILES, MetricsContext.Unit.COUNT); | |||
| } | |||
|
|
|||
| @Value.Derived | |||
| public Counter scannedDeleteManifests() { | |||
| return metricsContext().counter(SCANNED_DELETE_MANIFESTS, MetricsContext.Unit.COUNT); | |||
There was a problem hiding this comment.
Maybe we should make COUNT the default
There was a problem hiding this comment.
I created #5912 to do this
rdblue
approved these changes
Sep 29, 2022
|
Thanks, @nastra! Looks great. |
This was referenced Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently depends on #5788