AWS: Add socket connection timeout for Apache Http Builder #5787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackye1995
reviewed
Sep 22, 2022
jackye1995
reviewed
Sep 22, 2022
JonasJ-ap
commented
Sep 23, 2022
| } | ||
|
|
||
| @Test | ||
| public void testApacheConnectionSocketTimeoutConfiguration() { |
There was a problem hiding this comment.
These are newly added unit tests for the timeout configurations
jackye1995
reviewed
Sep 23, 2022
jackye1995
reviewed
Sep 23, 2022
jackye1995
reviewed
Sep 23, 2022
jackye1995
reviewed
Sep 24, 2022
|
cc @amogh-jahagirdar @rajarshisarkar @singhpk234 @xiaoxuandev @xingfanx for review |
amogh-jahagirdar
approved these changes
Sep 24, 2022
JonasJ-ap
force-pushed
the
add_socket_connection_timeout_for_apacheHttpBuilder
branch
from
417a0cd to
687c605
Compare
|
Rebase to the master branch |
JonasJ-ap
force-pushed
the
add_socket_connection_timeout_for_apacheHttpBuilder
branch
from
687c605 to
432f15a
Compare
|
Thanks for the work @JonasJ-ap and thanks for the review @amogh-jahagirdar ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can use
http-client.apache.socket-timeout-msandhttp-client.apache.connection-timeout-mstags to configure the connection and socket timeout for theApacheHttpClient.Add unit test to check the if the correct HTTP client type is configured