Spark: Fix runtime jars packaging scala library files #5754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @fqaiser94, @rdblue, @Fokko, @RussellSpitzer |
pan3793
reviewed
Sep 14, 2022
|
Have a quick check of spark runtime jar, |
Will handle it in the follow-up PR as it affects all the engine runtime jars and usually I get comments to separate the independent issues. |
ajantha-bhat
force-pushed
the
runtime
branch
from
9ce1fd3 to
dbd2f2f
Compare
pan3793
reviewed
Sep 14, 2022
spark/v3.3/build.gradle
Outdated
| implementation project(":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}") | ||
| implementation project(":iceberg-spark:iceberg-spark-extensions-${sparkMajorVersion}_${scalaVersion}") | ||
| implementation(project(":iceberg-spark:iceberg-spark-${sparkMajorVersion}_${scalaVersion}")) { | ||
| exclude group: 'org.scala-lang', module: 'scala-library' |
There was a problem hiding this comment.
My previous comment may be unclear, my suggestion is to add the following part after line 190
exclude group: 'org.scala-lang'
exclude group: 'org.scala-lang.modules'
There was a problem hiding this comment.
sounds good to me as spark is providing the scala.collection.compat also.
Updated the PR. Manually verified that there is no scala folder with the runtime jars. let's wait for the build.
ajantha-bhat
force-pushed
the
runtime
branch
2 times, most recently
from
4e6891b to
5e7f37b
Compare
ajantha-bhat
force-pushed
the
runtime
branch
from
5e7f37b to
801d82d
Compare
|
@KarlManong also verified these changes as mentioned in #5732 |
Fokko
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Looks good! Thanks @ajantha-bhat
After:
➜ iceberg git:(runtime) ls -lah spark/v3.3/spark-runtime/build/libs
total 53904
drwxr-xr-x 6 fokkodriesprong staff 192B Sep 14 15:37 .
drwxr-xr-x 8 fokkodriesprong staff 256B Sep 14 15:37 ..
-rw-r--r-- 1 fokkodriesprong staff 5.9K Sep 14 15:37 iceberg-spark-runtime-3.3_2.12-0.15.0-SNAPSHOT-javadoc.jar
-rw-r--r-- 1 fokkodriesprong staff 5.9K Sep 14 15:37 iceberg-spark-runtime-3.3_2.12-0.15.0-SNAPSHOT-sources.jar
-rw-r--r-- 1 fokkodriesprong staff 5.9K Sep 14 15:37 iceberg-spark-runtime-3.3_2.12-0.15.0-SNAPSHOT-tests.jar
-rw-r--r-- 1 fokkodriesprong staff 25M Sep 14 15:37 iceberg-spark-runtime-3.3_2.12-0.15.0-SNAPSHOT.jar
Before:
➜ iceberg git:(master) ls -lah spark/v3.3/spark-runtime/build/libs
total 64496
drwxr-xr-x 6 fokkodriesprong staff 192B Sep 14 15:39 .
drwxr-xr-x 8 fokkodriesprong staff 256B Sep 14 15:40 ..
-rw-r--r-- 1 fokkodriesprong staff 5.9K Sep 14 15:39 iceberg-spark-runtime-3.3_2.12-0.15.0-SNAPSHOT-javadoc.jar
-rw-r--r-- 1 fokkodriesprong staff 5.9K Sep 14 15:39 iceberg-spark-runtime-3.3_2.12-0.15.0-SNAPSHOT-sources.jar
-rw-r--r-- 1 fokkodriesprong staff 5.9K Sep 14 15:39 iceberg-spark-runtime-3.3_2.12-0.15.0-SNAPSHOT-tests.jar
-rw-r--r-- 1 fokkodriesprong staff 31M Sep 14 15:40 iceberg-spark-runtime-3.3_2.12-0.15.0-SNAPSHOT.jar
JonasJ-ap
pushed a commit
to JonasJ-ap/iceberg
that referenced
this pull request
Sep 18, 2022
* Spark: Fix runtime jars packaging scala library files * apply review comments
nastra
pushed a commit
to nastra/iceberg
that referenced
this pull request
Sep 29, 2022
* Spark: Fix runtime jars packaging scala library files * apply review comments
nastra
pushed a commit
to nastra/iceberg
that referenced
this pull request
Sep 29, 2022
* Spark: Fix runtime jars packaging scala library files * apply review comments
danielcweeks
pushed a commit
that referenced
this pull request
Sep 29, 2022
sunchao
pushed a commit
to sunchao/iceberg
that referenced
this pull request
May 10, 2023
* Spark: Fix runtime jars packaging scala library files * apply review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4009 adds a dependency on
scala.collection.compatwhich is bringing thescala-librarydependencies and causing the runtime jars to be packaged with scala-library files.So far, two issues reported that scala files packaged with run time jar is conflicting with their environment scala files.
Applicable only to spark-3.3 and spark-3.2 as PR#4009 is present only in these versions. This change also reduces the runtime jar size by 4MB!
Fixes #5732