Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: enforce LambdaMethodReference check at compile-time #5529

Merged
merged 1 commit into from
Aug 21, 2022

Conversation

XN137
Copy link
Contributor

@XN137 XN137 commented Aug 15, 2022

Follow-up to #5476 where the last violation was removed

the idea is to reduce review effort by enforcing this preference through a compile-time check instead of an ignorable warning

Copy link
Contributor

@kbendick kbendick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

If we find this gets in the way of beneficial code patterns, we can turn it off and suppress those warnings instead, but it is nice to not have to worry about littering the build log with warnings.

@nastra
Copy link
Contributor

nastra commented Aug 18, 2022

@rdblue thoughts on enforcing this at compile time?

@rdblue
Copy link
Contributor

rdblue commented Aug 21, 2022

This seems like a good idea to me.

@rdblue rdblue merged commit 73a6c90 into apache:master Aug 21, 2022
@XN137 XN137 deleted the errorprone-LambdaMethodReference branch August 22, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants