[1.0.x] Enforce & Apply spotless #5374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the minimal set of checkstyle rules that were conflicting with the code format that Spotless would apply. Additionally, this adds a few `MethodLength` suppressions since those methods will become slightly longer than the limit after formatting has been applied.
Given that CI runs builds with JDK 8 & 11, the google-java-format will actually pick different google-java-format versions depending on the JDK being used (JDK8=google-java-format 1.7 / JDK11=google-java-format latest). Those different google-java-format version are actually producing different formatting results, thus we have to use google-java-format 1.7 here to make things consistent across JDK versions.
The actual command needs to be executed with JDK 8: ./gradlew spotlessApply -DflinkVersions=1.13,1.14,1.15 -DsparkVersions=2.4,3.0,3.1,3.2,3.3 -DhiveVersions=2,3 --no-build-cache
|
Thanks, @nastra! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.