Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS - Fix ErrorProne warning of malformed Javadoc #5359

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

kbendick
Copy link
Contributor

@kbendick kbendick commented Jul 26, 2022

Noticed this error prone warning when checking my work for warnings.

This fixes the malformed JavaDoc on the GLUE_CATALOG_ENDPOINT configuration constant.

> Task :iceberg-aws:compileJava
/Users/kylebendickson/repos/iceberg/aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:130: warning: [AlmostJavadoc] This comment contains Javadoc or HTML tags, but isn't started with a double asterisk (/**); is it meant to be Javadoc?
  public static final String GLUE_CATALOG_ENDPOINT = "glue.endpoint";
                             ^
    (see https://errorprone.info/bugpattern/AlmostJavadoc)
  Did you mean '/**'?

@kbendick
Copy link
Contributor Author

Sorry looked at the wrong git blame:

cc @naushadh @amogh-jahagirdar

@amogh-jahagirdar
Copy link
Contributor

Ah thanks for cleaning this up! LGTM

@github-actions github-actions bot added the AWS label Jul 26, 2022
@xiaoxuandev
Copy link
Contributor

Thanks for the fix!

@aokolnychyi aokolnychyi merged commit 7c88e99 into apache:master Jul 26, 2022
@aokolnychyi
Copy link
Contributor

Nice catch, @kbendick!

@kbendick kbendick deleted the kb-fix-almost-javadoc-in-aws branch July 26, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants