Flink: change precondition check to allow table pass in #5357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenzwu
requested changes
Jul 26, 2022
There was a problem hiding this comment.
I understand the need to pass in the table directly to avoid double loading on the jobmanager side. It is already supported in the current API.
tableLoader should always be provided, as it needs to be serializable to be used by the committer operator. SerializableTable won't work for committer, as it is a ready-only copy of the Table and can't be used to change table state.
I think we should not make the change in this PR.
|
Thanks @stevenzwu for the explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change precondition to allow passing in the table instance.
Sometimes the table is already loaded and accessed before building the sink, this change can avoid load the table again.