Core: Add length arg to FileIO.newInputFile #5207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcweeks
reviewed
Jul 5, 2022
| @@ -67,6 +67,6 @@ public PositionOutputStream createOrOverwrite() { | |||
|
|
|||
| @Override | |||
| public InputFile toInputFile() { | |||
| return new GCSInputFile(storage(), blobId(), gcpProperties(), metrics()); | |||
| return new GCSInputFile(storage(), blobId(), null, gcpProperties(), metrics()); | |||
There was a problem hiding this comment.
Could we just use GCSInputFile.fromLocation(...) to avoid calling the constructor with null?
There was a problem hiding this comment.
I just didn't want to change very much here. We probably could.
danielcweeks
reviewed
Jul 5, 2022
| @@ -70,7 +70,7 @@ public PositionOutputStream createOrOverwrite() { | |||
|
|
|||
| @Override | |||
| public InputFile toInputFile() { | |||
| return new S3InputFile(client(), uri(), awsProperties(), metrics()); | |||
| return new S3InputFile(client(), uri(), null, awsProperties(), metrics()); | |||
There was a problem hiding this comment.
Similar to GCS, could we just call S3InputFile.fromLocation(...) to avoid calling the constructor with null?
danielcweeks
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #5206, I found that a lot of time is spent in
InputFile#getLength()for manifest files during job planning. This isn't necessary becauseManifestFilestored in a manifest list has the manifest file length. This PR avoids round-trip calls to get object lengths by passing the length intoFileIO.newInputFile. This implements the improvement for S3, GCP, and Hadoop.