API: Add generic FileIO JSON serialization #5178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcweeks
reviewed
Jul 1, 2022
danielcweeks
reviewed
Jul 1, 2022
danielcweeks
reviewed
Jul 1, 2022
| public static String generate(ToJson toJson, boolean pretty) { | ||
| try { | ||
| StringWriter writer = new StringWriter(); | ||
| JsonGenerator generator = JsonUtil.factory().createGenerator(writer); |
There was a problem hiding this comment.
The JsonGenerator is closable, so we should probably be using TWR or closing with finally.
danielcweeks
approved these changes
Jul 3, 2022
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
* API: Add generic FileIO JSON serialization. * Fix checkstyle. * Close StringWriter and JsonGenerator.
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
* API: Add generic FileIO JSON serialization. * Fix checkstyle. * Close StringWriter and JsonGenerator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a JSON parser to serialize FileIO instances to and from JSON. The format is an object with an
io-impland configurationproperties. Deserialization usesCatalogUtilto re-create an instance from an environment Hadoop Configuration (optional), the IO impl class, and the configuration used to create the originalFileIO.