Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: bump Hadoop version to 3.2.0 #5024

Closed
wants to merge 2 commits into from

Conversation

steveloughran
Copy link
Contributor

Hadoop 3.2.0 is the first release to support java 11, among
other improvements.

Includes a fix for AliyunOSSMockLocalStore to compile by changing
to a different implementation of encodeHex on the classpath
and adding commons-io as a test-time dependency.

This is the first release to support java 11, among
other improvements.

Includes a fix for AliyunOSSMockLocalStore to compile by changing
to a different implementation of encodeHex on the classpath
and adding commons-io as a test-time dependency.
@steveloughran
Copy link
Contributor Author

for anyone wondering "why 3.2.0 and not 3.2.3?": you need to upgrade hive from 3.2.1+ just to get guava versions lined up.

@steveloughran steveloughran marked this pull request as draft June 13, 2022 17:40
@steveloughran
Copy link
Contributor Author

steveloughran commented Jun 13, 2022

TEZ-3853 Binary incompatibility caused by DEFAULT_LOG_LEVEL

it looks like hive/tez will need some version update, because the version of tez used in the tests isn't compatible with hadoop branch 3. This is going to make for a more traumatic change

@@ -37,8 +37,8 @@
import java.util.List;
import java.util.Locale;
import java.util.Map;
import org.apache.commons.codec.binary.Hex;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try not to rely on Apache Commons for anything to avoid a direct dependency, even in tests (though it looks like that was already violated). Is there an easy way to replace this? We should be able to replace FileUtils with a readFully method in IOUtil

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commons code it was on the classpath already and i just needed any hex.encode call. There's a couple more...let me find them and see which is preferable

@rdblue
Copy link
Contributor

rdblue commented Jun 14, 2022

you need to upgrade hive from 3.2.1+ just to get guava versions lined up.

Iceberg shades Guava to avoid conflicts. Do we need to worry about this?

@steveloughran
Copy link
Contributor Author

hive and tez turn out to have problems in the public branches; ASF hive is currently only building against 3.1 until apache/hive#3279 is in. I'm going to avoid touching this PR for a bit while I see about getting parquet building against 3.2 first

@pan3793
Copy link
Member

pan3793 commented Jun 14, 2022

is there possible to use hadoop shaded client?
https://issues.apache.org/jira/browse/HADOOP-11656

@rdblue
Copy link
Contributor

rdblue commented Jun 24, 2022

@pan3793, Iceberg should declare its dependencies correctly. If you want to use a shaded version downstream, you can exclude and change the dependency tree.

@Fokko
Copy link
Contributor

Fokko commented Apr 19, 2023

@steveloughran Parquet 1.13 has been released recently and compiles against Hadoop 3.2.3

@steveloughran
Copy link
Contributor Author

@Fokko i really am not active on this...if you want to take on the "bump things up" project, that'd be wonderful for me.

@steveloughran
Copy link
Contributor Author

giving up on the eternal movign target here. focusing on reflection based access to the cloud-friendly APIs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants