Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Add explicit call to revapi github action to ensure it's not skipped #4974

Closed
wants to merge 1 commit into from

Conversation

kbendick
Copy link
Contributor

@kbendick kbendick commented Jun 6, 2022

The revapi action is sometimes skipping.

This is possibly due to the cache (in which case we'd need to be more explicit about which dependencies are cached).

We can either try this or ./gradlew clean :iceberg-api:build -x test -x integrationTest -x javadoc to try it out. I'm open to either.

I'll look into the revapi action upstream to see if there's a better way we can force it or if they have any guidance. This worked locally for me though as clean should force iceberg-api:revapi to invoke build.

cc @singhpk234 @ajantha-bhat

@github-actions github-actions bot added the INFRA label Jun 6, 2022
@kbendick
Copy link
Contributor Author

kbendick commented Jun 6, 2022

I think we can also mark this as not up to date, or run this particular action without clean, but with --rerun-tasks.

See https://stackoverflow.com/questions/42175235/force-gradle-to-run-task-even-if-it-is-up-to-date

@ajantha-bhat
Copy link
Member

can we also do some dummy changes in the api/ module (until the review is done)? So, it will run the rev api check? Now out of 26 checks it ran, I don't see the rev api check.

@@ -46,7 +46,7 @@ jobs:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle
- run: ./gradlew :iceberg-api:revapi
- run: ./gradlew clean :iceberg-api:revapi -x test -x integrationTest -x javadoc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is :iceberg-api:revapi success cached from earlier runs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not entirely.

The problem, as outlined in the new PR #4989, was that the actions/checkout github action uses a depth of 1 by default.

So the "head" (master) branch is in a detached state, and thus the tags needed for the action to work (basically the output of git describe) was failing.

I did remove the cache, which then caused the tests to at least run revapi. But they still passed because the plugin couldn't properly determine the old version (via the tag) and then the new version via the override in the .palantir/revapi.yaml file).

Let's continue the discussion in #4989

@kbendick
Copy link
Contributor Author

kbendick commented Jun 7, 2022

Replaced by #4989

@kbendick kbendick closed this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants