Use CatalogUtil classloader instead of context classloader for FileIO #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanck
approved these changes
Jun 3, 2022
danielcweeks
force-pushed
the
catalogutil-fileio-classloader
branch
from
99ab36a to
7b981fa
Compare
rdblue
approved these changes
Jun 3, 2022
rdblue
approved these changes
Jun 3, 2022
kbendick
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
+1. Good catch @danielcweeks! We have indeed encountered this before so if tests are green then lgtm.
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
…apache#4957) * Use CatalogUtil classloader instead of context classloader for FileIO * Use AwsClientFactories classloader for loading custom client factory * Set classloader for S3FileIO metrics dynamic loading
namrathamyske
pushed a commit
to namrathamyske/iceberg
that referenced
this pull request
Jul 10, 2022
…apache#4957) * Use CatalogUtil classloader instead of context classloader for FileIO * Use AwsClientFactories classloader for loading custom client factory * Set classloader for S3FileIO metrics dynamic loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the context classloader to dynamically load FileIO will cause problems in systems like Trino where the context classloader comes from a different plugin (e.g. information schema or describe table).
The classloader that loaded the
CatalogUtilshould have be the same classloader as the FileIO.