AWS: use pre-created IAM role for AssumeRole related integration tests #4909
Conversation
| @@ -117,7 +65,7 @@ public void testAssumeRoleGlueCatalog() throws Exception { | |||
| Assert.assertEquals(AccessDeniedException.class, e.getClass()); | |||
| } | |||
|
|
|||
| Namespace namespace = Namespace.of("allowed_" + UUID.randomUUID().toString().replace("-", "")); | |||
| Namespace namespace = Namespace.of("iceberg_aws_ci_" + UUID.randomUUID().toString().replace("-", "")); | |||
There was a problem hiding this comment.
Nit: iceberg_aws_ci_ maybe could be a static prefix? Not blocking though considering it was already like that
| try { | ||
| inputFile.exists(); | ||
| s3Client.getBucketAccelerateConfiguration(GetBucketAccelerateConfigurationRequest.builder() |
There was a problem hiding this comment.
I guess here we can use any method, so it does not matter but would getBucket just be less verbose to read?
| @@ -88,6 +88,10 @@ public static String testAccountId() { | |||
| return System.getenv("AWS_TEST_ACCOUNT_ID"); | |||
| } | |||
|
|
|||
| public static String testAssumeRoleArn() { | |||
| return System.getenv("AWS_TEST_ASSUME_ROLE_ARN"); | |||
There was a problem hiding this comment.
@jackye1995, we recently added EnvironmentUtil that can resolve properties using environment variables in #5018. Can we use that here instead of adding this?
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
as a part of AWS CI effort, remove IAM role that is created during tests and use a pre-created IAM role. The role creation and configuration step will be defined in a CDK stack for easy developer setup.
@amogh-jahagirdar @xiaoxuandev @rajarshisarkar @singhpk234