Core - Use unbound variants of SortOrder / PartitionSpec for REST Catalog's CreateTableRequest #4880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ableRequest for REST Catalog
|
As mentioned, additional tests that exercise the exact SerDe of these classes are coming, but this patch is necessary to make testing out the REST catalog in its current form easier so I figured we might as well not wait on those other PRs =) This code is indeed tested via |
|
Also, I wanted to get the small change to the API module (changing access modifier of |
rdblue
reviewed
May 27, 2022
| private PartitionSpec spec; | ||
| private SortOrder order; | ||
| private UnboundPartitionSpec spec; | ||
| private UnboundSortOrder order; |
There was a problem hiding this comment.
We need to make sure we follow up with a serialization test for this class.
rdblue
approved these changes
May 27, 2022
|
Thanks, @kbendick! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I've been working on some serialization related tests for the REST catalog, it came to my attention that we should be storing the create table requests sort order and partition spec as
UnboundSortOrderandUnboundPartitionSpec, respectively.Generally speaking, we are moving towards using
Unboundvariants of all things whenever possible, and letting the binding to actual fields take place later in the process.I am working on some PRs that add additional serialization tests in, but I wanted to get these changes in sooner so that anybody who might be implementing or testing agains the RESTCatalog would have these changes available to them.