Add Poetry build and release instructions #4844
Conversation
Fokko
commented
May 23, 2022
•
Fokko
commented
- Migrate from the setup.cfg to pyproject.toml
- Add poetry.lock for pinning all the dependencies, to make sure that we exactly know which libraries are installed
- Add detailed instruction on how to run a release
Fokko
force-pushed
the
fd-add-build-instructions
branch
2 times, most recently
from
310e6ff
to
5ac2540
Compare
- Migrate from the setup.cfg to pyproject.toml - Add poetry.lock for pinning all the dependencies, to make sure that we exactly know which libraries are installed - Add detailed instruction on how to run a release
Fokko
force-pushed
the
fd-add-build-instructions
branch
from
5ac2540
to
3932350
Compare
Fokko
changed the title
|
This looks good to me, but I'd love to hear what other python people think about moving to poetry. |
|
|
||
| Testing is done using tox. The config can be found in `tox.ini` within the python directory of the iceberg project. | ||
| ## Development |
There was a problem hiding this comment.
It would be good to have a setup section that instructs you to run pip install poetry.
There was a problem hiding this comment.
I also had to upgrade pip and virtualenv in Ubuntu 20.04 to get poetry working properly.
There was a problem hiding this comment.
sudo pip install virtualenv --upgrade and sudo python3 -m pip install --upgrade pip
There was a problem hiding this comment.
Cool, I've added the commands 👍🏻 btw, some interesting combinations you have there. sudo shouldn't be required, and pip install and python3 -m pip install are equivalent.
There was a problem hiding this comment.
I think this is a good change overall. It's nice to have a lock file and poetry seems really friendly. What I like most is that there is an IntelliJ plugin that I was easily able to get working so my IDE environment and CLI environment are mostly the same (fixtures don't work yet, but I probably just need to configure IntelliJ).
…d-build-instructions
|
Hey @rdblue thanks for giving this a try. Unfortunately, the IDEA plugin seems to be outdated; https://plugins.jetbrains.com/plugin/14307-poetry/versions Only available for <= 2021 🤔 |
Fokko
force-pushed
the
fd-add-build-instructions
branch
2 times, most recently
from
27b67cd
to
ba7ae10
Compare
Fokko
force-pushed
the
fd-add-build-instructions
branch
from
ba7ae10
to
292305c
Compare
|
@rdblue It is actually part of Intellij now 🥳 |
