Aliyun: Deprecate OSSInputStream public constructor #4450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
reviewed
Mar 31, 2022
| /** | ||
| * @deprecated moving to package-private in 0.15.0 | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
Should the class itself also be moved to package-private?
There was a problem hiding this comment.
Yes, that would maintain parity with GCSInputStream, EcsSeekableInputStream, and S3InputStream as well.
rajarshisarkar
force-pushed
the
deprecate-oss-input-stream-public-constructor
branch
from
37827ef to
5a2c97e
Compare
|
Thanks for the quick review, @openinx! |
kbendick
pushed a commit
to kbendick/iceberg
that referenced
this pull request
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of @rdblue's feedback: #4393 (comment)
Deprecating the constructor would maintain parity with the other InputStream classes like
GCSInputStream,EcsSeekableInputStream, andS3InputStreamwhich have a package private constructor.cc: @rdblue