-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALL:fixing static analysis warnings #4376
Conversation
please review again,thanks @RussellSpitzer |
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/ArrowReader.java
Outdated
Show resolved
Hide resolved
flink/v1.12/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java
Show resolved
Hide resolved
flink/v1.12/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java
Show resolved
Hide resolved
flink/v1.12/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java
Outdated
Show resolved
Hide resolved
flink/v1.13/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java
Show resolved
Hide resolved
...a/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergTimestampObjectInspectorHive3.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these look fine, I would if possible (and I know I asked to group these together) separate out the changes which make semantic changes to the code into their own PR's.
For example
"Removing an initialization that sets a variable to null" Good, keep here doesn't actually change anything
"Removing a fully defined type that is already imported" good keep here
"Supressions we know are false positive" Keep here
"Removing empty java docs, fixing java docs" Keep here
"Changing parens" Keep here
--
"Changes an iterator to a list" Separate PR
"Changing the access modifiers on all the JDBC Static Values" Separate PR
"Changes in date handling classes" Separate PR
I will separate out the changes which make semantic changes to the code into their own PR's. |
The task was not fully completed,It will be finished today. @RussellSpitzer |
this PR fixed these grouping parentheses are unnecessary. cc @rdblue @RussellSpitzer