Build: Update spotless version and add spotless tasks #4077
Conversation
This adds the three spotless tasks to the build: ``` spotlessApply - Applies code formatting steps to sourcecode in-place. spotlessCheck - Checks that sourcecode satisfies formatting steps. spotlessDiagnose ```
nastra
changed the title
| @@ -48,6 +49,8 @@ subprojects { | |||
| // import order. | |||
| pluginManager.withPlugin('com.diffplug.spotless') { | |||
| spotless { | |||
| // don't run spotlessCheck during gradle check task | |||
| enforceCheck = false | |||
There was a problem hiding this comment.
So is this just something we run ourselves or when does it get run?
There was a problem hiding this comment.
so previously the gradle spotless plugin was already there, but never enabled. This PR enables it and makes sure it doesn't run during the normal check of Gradle because it will complain that the code format is off.
The implication of this is that we would run spotlessCheck / spotlessApply manually for now until the format of the codebase is in a state where we can enforce this on CI. Bringing the codebase into this state is what I wanted to focus on in a separate PR/discussion and I started already talking to @rdblue about it.
There was a problem hiding this comment.
That makes sense to me.
Thank you for filling me in on the details as I've had less bandwidth for doing reviews than I normally do. Makes sense to add it in and then slowly updated over time. I'll be sure to remind people ocassionally to run spotlessCheck during PRs.
There was a problem hiding this comment.
Additional work needs to happen (which I'm looking into) before we can have spotlessCheck produce the actual code format that is desired btw :)
There was a problem hiding this comment.
This looks good to me but I have some questions, so a soft +1.
I'm a little confused on why we're adding the enforceCheck = false. How does this change from the previous behavior? I see we didn't apply the plugin before so maybe that section is only now becoming relevant?
This adds the three spotless tasks to the build: ``` spotlessApply - Applies code formatting steps to sourcecode in-place. spotlessCheck - Checks that sourcecode satisfies formatting steps. spotlessDiagnose ```
This adds the three spotless tasks to the build: