Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Use wildcard version for Hive and Tez #3510

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

marton-bod
Copy link
Collaborator

@marton-bod marton-bod commented Nov 9, 2021

This PR will extract the Hive and Tez versions into a variable and have the projects use these variables.
This helps:

  • remove duplication from the versions.props file (it has 4 different Hive entries and 2 Tez entries currently)
  • remove potential for mistake of adding new Hive dependencies with the wrong version number

@marton-bod
Copy link
Collaborator Author

@rdblue can you please take a look as well when you have some time? Thanks so much

@rdblue
Copy link
Contributor

rdblue commented Nov 14, 2021

Are you sure this is needed? I think a couple wildcards in versions.props could accomplish the same thing?

@marton-bod marton-bod changed the title Build: extract Hive and Tez dependency versions into variables Build: Use wildcard version for Hive and Tez Nov 15, 2021
@marton-bod
Copy link
Collaborator Author

@rdblue Thanks Ryan! I seem to remember having issues in the past with using wildcards for Hive specifically - when using *, it forced the 2.3.8 version on all the transitive org.apache.hive dependencies as well, and one of them didn't have this version available. But checking it again, it seems that this issue is gone, so I've changed the PR to use the wildcards for Hive and Tez. Thanks for the suggestion!

@rdblue rdblue merged commit 061ac89 into apache:master Nov 15, 2021
@rdblue
Copy link
Contributor

rdblue commented Nov 15, 2021

Thanks for updating it, @marton-bod! I merged this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants