Investigate amount of work needed to backport #3240 to 0.12.1 #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Core: Add TypeUtil.project() for Explicit Projection Previously we only had TypeUtil.select which would select all nested elements of selected structs. This made it difficult to project empty structs since they would have no selected leaf elements. The new TypeUtil.project instead takes only the elements which are specifically requested with no automatic selection of nested elements.
|
Unfortunately this is quite a lot of new things to backport for this fix. This fix will go out with the next major version release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating how much work would be required for cherry-picking #3240 to fix up some Flink CDC stuff.
At this point, given the number of changes needed to cherry-pick it cleanly, it might not be able to make it into a patch release (though 0.13.0 should be coming soon).
I think if users don't select * they should be ok though.Update: selecting a subset of fields does not work around the issue, as we add _pos to the position delete files and the internals still wind up needing to parse it (before adding these patches)// This one will make 2953 clean.
Core: Add TypeUtil.project() for Explicit Projection #2952 - 599ee22 - Clean (Merged Sept 2nd)
API: Change GetProjectedIds to Return all Ids #2953 - fafe33a - Clean (Merged 29 days ago)
Finally
HOWEVER, it didn't build! After applying the next patch, it builds. But quite a lot of arguably new features are included.
// Might also need the following as it's referenced in the above PR
// It's just validations for unknown partition types so readers fail gracefully.