ORC: Fix importing ORC files with float and double columns

[rdblue]

The OrcMetrics code assumed that Iceberg metrics would be available, but that isn't the case when importing existing ORC files.

[yyanyy]

LGTM! Might want to modify fromOrcMax for the same? Also I wonder if a similar change is required for importing parquet files as well...

[yyanyy]

wondering if we want to reassign min to negative infinite if the this value tracked by ORC is NaN

[rdblue]

Good point. I forgot to update max.

[kbendick]

I have been testing this, but it looks like the same thing needs to be done for the max (this seems to be just the min).

iceberg/orc/src/main/java/org/apache/iceberg/orc/OrcMetrics.java

Lines 236 to 242 in 7a58028

	} else if (columnStats instanceof DoubleColumnStatistics) {
	// since Orc includes NaN for upper/lower bounds of floating point columns, and we don't want this behavior,
	// we have tracked metrics for such columns ourselves and thus do not need to rely on Orc's column statistics.
	Preconditions.checkNotNull(fieldMetrics,
	"[BUG] Float or double type columns should have metrics being tracked by Iceberg Orc writers");
	max = fieldMetrics.upperBound();
	} else if (columnStats instanceof StringColumnStatistics) {

[kbendick]

Good point. I forgot to update max.

I'm applying the same changes to max in the branch I'm testing in. So far, the min fixes seem to work.

[kbendick]

I added tests for this here: #3332

I first verified that I hit the error, then added in the min fix here, got the max error, and then added that fix as well.

[rdblue]

Closing in favor of #3332.