Build: Run Hive tests in separate CI actions #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spark tests are running because this also pulled Spark jobs into spark-ci.yml. |
rdblue
commented
Oct 17, 2021
| path: | | ||
| **/build/testlogs | ||
|
|
||
| spark2-tests: |
There was a problem hiding this comment.
Moved into spark-ci.yml.
rdblue
commented
Oct 17, 2021
|
|
||
| def hiveVersions = (System.getProperty("hiveVersions") != null ? System.getProperty("hiveVersions") : System.getProperty("defaultHiveVersions")).split(",") | ||
|
|
||
| project(':iceberg-mr') { |
There was a problem hiding this comment.
These were copied directly from build.gradle. They are unchanged except for the additional check for the Hive 3 dependency in hive-runtime. If Hive 3 isn't part of the build, it is excluded. By default, both 2 and 3 are in the build.
rdblue
commented
Oct 17, 2021
|
|
||
| // The purpose of this module is to re-shade org.apache.orc.storage to the original org.apache.hadoop.hive package | ||
| // name. This is to be used by Hive3 for features including e.g. vectorization. | ||
| project(':iceberg-hive3-orc-bundle') { |
There was a problem hiding this comment.
These were copied directly from build.gradle and haven't been modified.
|
LGTM |
|
Thanks, @aokolnychyi! |
This was referenced Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new property,
hiveVersions, that controls whether Hive modules are added to the build. This is similar to recent changes for Spark in #3298. Now, the core test job no longer runs Hive or Spark tests. Instead, Hive tests are run individually by the hive-ci.yml configuration. Hive 2 and Hive 3 tests run in separate jobs so they run in parallel. This should decrease the overall time it takes for CI to validate changes, especially for Java 8. In addition, failures should happen sooner, which will cancel other tests and save overall CI resources.