Hive: Reconnect client if connection exception is wrapped in RuntimeE…

[dengzhhu653]

…xception

iceberg/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java

Line 303 in d5443e3

ALTER_TABLE.invoke(client, database, tableName, hmsTable, envContext);

wraps the internal exception into a RuntimeException and throws, the Hive client may fail to reconnect if if the internal exception is an exception that should reconnect. For example,

java.lang.RuntimeException: org.apache.thrift.transport.TTransportException: java.net.SocketTimeoutException: Read timed out
        at org.apache.iceberg.relocated.com.google.common.base.Throwables.propagate(Throwables.java:241)
        at org.apache.iceberg.common.DynMethods$UnboundMethod.invoke(DynMethods.java:80)

Reusing the timeout client may result to org.apache.thrift.TApplicationException: get_table failed: out of sequence response.

[szehon-ho]

I think this may not necessary anymore because of #3099, what do you think?

[dengzhhu653]

I think this may not necessary anymore because of #3099, what do you think?

yeap, it's much better to use the proxy client for retrying, thank you for the feedback and comment.