Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spark3 structured streaming micro_batch read support #2660
Spark3 structured streaming micro_batch read support #2660
Changes from 18 commits
41041f3
51c9e87
1b7dbb0
5a1020f
6f57b55
6fe5657
15efe95
9c9b4de
b4acade
cab843b
5e59082
fa85859
96aaa22
f286cee
2ac1269
7ed9781
6ee958c
c101a9e
ce16a76
baa03d6
78e5bdb
00fe477
cb4f200
33bf3c5
353f274
f22a587
75e8430
3c60ef8
d671d5e
344ed1f
f33b26e
9b2fd4e
cc7c887
da2528b
fadd15c
8bb4048
12c675a
507f7d8
2baebb1
7467c0c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the rationale behind the location here?
Also, this code doesn't need to rely on Hadoop's
Path
. Instead, I'd recommend using a private static joiner namedSLASH
and callingSLASH.join(checkpointLocation, "offsets/0")
instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unresolving this so it is more obvious later if we refer back to this PR.