Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core : snatshot read with schema change #2522

Closed
wants to merge 1 commit into from

Conversation

zhangjun0x01
Copy link
Contributor

When we modify the schema of the iceberg table and do a time travel query by specifying the snapshot-id, the query result shows the current latest schema, but we want the schema of query result to be corresponding with the snapshot.

I add a schema-id to the snapshot in metadata , when we query by snapshot-id , we get the schema by the schema-id in the snapshot

@rdblue @aokolnychyi @openinx could you help me review it ? thanks.

@zhangjun0x01
Copy link
Contributor Author

I found that this pr seems to be duplicate. I found other similar pr (#2275 ,#2096). I will close this pr, but I think we should add test cases for different computing engines (spark, flink, hive) so that they can works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant