Hive: Add ObjectInspector implementations for UUID, Fixed and Time type #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pvary @marton-bod If you have some spare time, could you please have a look at this PR? Thanks |
pvary
reviewed
Jan 13, 2021
.../main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergFixedObjectInspector.java
Show resolved
Hide resolved
pvary
reviewed
Jan 13, 2021
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
Show resolved
Hide resolved
pvary
reviewed
Jan 13, 2021
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
Show resolved
Hide resolved
pvary
reviewed
Jan 13, 2021
...t/java/org/apache/iceberg/mr/hive/serde/objectinspector/TestIcebergFixedObjectInspector.java
Show resolved
Hide resolved
pvary
reviewed
Jan 13, 2021
...st/java/org/apache/iceberg/mr/hive/serde/objectinspector/TestIcebergTimeObjectInspector.java
Show resolved
Hide resolved
pvary
reviewed
Jan 13, 2021
...st/java/org/apache/iceberg/mr/hive/serde/objectinspector/TestIcebergUUIDObjectInspector.java
Show resolved
Hide resolved
|
@lcspinter: Thanks for the PR and the fixes. LGTM +1 non-binding |
pvary
approved these changes
Jan 15, 2021
|
Looks like this needs to be updated after merging the fix to use source object inspectors. It should probably have the same fix applied, too? |
lcspinter
force-pushed
the
missing_types
branch
from
7c1ca44 to
420ec06
Compare
lcspinter
force-pushed
the
missing_types
branch
from
420ec06 to
3ba4dbb
Compare
rdblue
reviewed
Jan 16, 2021
| ByteBuffer copy = ByteBuffer.wrap(((ByteBuffer) o).array(), ((ByteBuffer) o).arrayOffset(), | ||
| ((ByteBuffer) o).limit()); | ||
| ByteBuffer copy = | ||
| ByteBuffer.wrap(((ByteBuffer) o).array(), ((ByteBuffer) o).arrayOffset(), ((ByteBuffer) o).limit()); |
There was a problem hiding this comment.
Does this just change formatting? If so, please revert it.
There was a problem hiding this comment.
No need, since this is the only issue, I'll merge with it.
rdblue
approved these changes
Jan 16, 2021
|
Thanks @lcspinter! |
XuQianJin-Stars
pushed a commit
to XuQianJin-Stars/iceberg
that referenced
this pull request
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers the schema conversion for UUID, Fixed and Time types between Iceberg and Hive.
The following mapping is used: