AWS: fix bugs around using S3FileIO for table operations #1749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used in
BaseMetastoreTableOperations
, inTableMetadataParser.internalWrite()
, an output stream is closed twice because of the closure of the output stream and its writer:This causes issue in
S3OutputStream
because the stream uploads the file from local to S3 during the call to close.Also,
S3FileIO
cannot be properly initialized when there are multiple HTTP client builders available in the Java class path at runtime, soAwsClientUtil
is used to provide a stable default client forS3FileIO
to use.