Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve log settings in Hive unit tests #1712

Merged
merged 4 commits into from
Nov 18, 2020
Merged

Improve log settings in Hive unit tests #1712

merged 4 commits into from
Nov 18, 2020

Conversation

marton-bod
Copy link
Collaborator

@marton-bod marton-bod commented Nov 3, 2020 •
edited
Loading

  • Current log4j properties is only used by Hive2 and DataNucleus but not Hive3 -> adding a log4j2 props file to drive logging configuration for Hive3
  • Changing root log level to warn to remove log noise (e.g. datanucleus debug logs), this can be tuned back to lower levels whenever debugging is needed
  • Enabling a flag to print execution summary and counter values for Tez queries (DAG stages, execution times, number of records/bytes read/written, etc.)

cc @rdblue @pvary

@github-actions github-actions bot added the MR label Nov 3, 2020
@github-actions github-actions bot added the hive label Nov 3, 2020
rdblue
rdblue reviewed Nov 3, 2020
View reviewed changes
mr/src/test/resources/log4j.properties
# See the License for the specific language governing permissions and
# limitations under the License.
#

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right license header. It should be the "Licensed to the Apache Software Foundation . . ." one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes right, I've updated them with the correct ASF header

@rdblue rdblue merged commit d1d1fff into apache:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdblue rdblue rdblue left review comments

Assignees
No one assigned
Labels
hive MR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marton-bod @rdblue