Repository navigation
Fix IN predicate performance - #1672
Merged
Merged
Conversation
Contributor
Author
|
I've created this one as a temp solution to the IN predicate issue instead of #1672. |
Contributor
Author
RussellSpitzer
approved these changes
Oct 28, 2020
rdblue
approved these changes
Oct 28, 2020
Member
|
I believe you mean in place of #1665 but 👍 |
Contributor
|
+1 when tests are passing. Thanks for splitting this out, I think it will be helpful! |
Contributor
Author
|
I cancelled the build since Travis did not start it for a while. |
Contributor
Author
|
I am merging this. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the IN predicate performance using hard-coded values.
Resolves #1588.