Extract FixupTypes to Iceberg from Spark #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
reviewed
Aug 27, 2020
| */ | ||
| class FixupTypes extends TypeUtil.CustomOrderSchemaVisitor<Type> { | ||
| public abstract class FixupTypes extends TypeUtil.CustomOrderSchemaVisitor<Type> { |
There was a problem hiding this comment.
Sorry this class is so complicated. It's really just a Schema with partner visitor, but that pattern wasn't around when we needed to write this, so I used the custom order visitor. I should eventually go clean these up!
|
@JingsongLi, thanks for working on this. I think it's a good idea. The only problem is that this moves the FixupTypes class to API. I'd rather not publish that in the API module, which we maintain with stricter guarantees because it is a user-facing API (core is a developer-facing API). Can you move it to core instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.