Fix all Single Line Constructors

We decided to enforce no single line constructors

.baseline/checkstyle/checkstyle.xml

@@ -356,7 +356,7 @@
         </module>
         <module name="RightCurly"> <!-- Java Style Guide: Nonempty blocks: K & R style -->
             <property name="option" value="alone"/>
-            <property name="tokens" value="CLASS_DEF, METHOD_DEF, LITERAL_FOR, LITERAL_WHILE, STATIC_INIT, INSTANCE_INIT"/>
+            <property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, STATIC_INIT, INSTANCE_INIT"/>
         </module>
         <module name="SeparatorWrap"> <!-- Java Style Guide: Where to break -->
             <property name="tokens" value="DOT"/>

api/src/main/java/org/apache/iceberg/Files.java

@@ -34,7 +34,8 @@
 
 public class Files {
 
-  private Files() {}
+  private Files() {
+  }
 
   public static OutputFile localOutput(File file) {
     return new LocalOutputFile(file);

api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java

@@ -27,7 +27,8 @@
  */
 public class ExpressionVisitors {
 
-  private ExpressionVisitors() {}
+  private ExpressionVisitors() {
+  }
 
   public abstract static class ExpressionVisitor<R> {
     public R alwaysTrue() {

api/src/main/java/org/apache/iceberg/transforms/ProjectionUtil.java

@@ -34,7 +34,8 @@
 
 class ProjectionUtil {
 
-  private ProjectionUtil() {}
+  private ProjectionUtil() {
+  }
 
   static <T> UnboundPredicate<T> truncateInteger(
       String name, BoundLiteralPredicate<Integer> pred, Transform<Integer, T> transform) {

api/src/main/java/org/apache/iceberg/transforms/TransformUtil.java

@@ -30,7 +30,8 @@
 
 class TransformUtil {
 
-  private TransformUtil() {}
+  private TransformUtil() {
+  }
 
   private static final OffsetDateTime EPOCH = Instant.ofEpochSecond(0).atOffset(ZoneOffset.UTC);
   private static final int EPOCH_YEAR = EPOCH.getYear();

api/src/main/java/org/apache/iceberg/types/Comparators.java

@@ -30,7 +30,8 @@
 
 public class Comparators {
 
-  private Comparators() {}
+  private Comparators() {
+  }
 
   private static final ImmutableMap<Type.PrimitiveType, Comparator<?>> COMPARATORS = ImmutableMap
       .<Type.PrimitiveType, Comparator<?>>builder()

api/src/main/java/org/apache/iceberg/types/Conversions.java

@@ -36,7 +36,8 @@
 
 public class Conversions {
 
-  private Conversions() {}
+  private Conversions() {
+  }
 
   private static final String HIVE_NULL = "__HIVE_DEFAULT_PARTITION__";
 

api/src/main/java/org/apache/iceberg/types/TypeUtil.java

@@ -37,7 +37,8 @@
 
 public class TypeUtil {
 
-  private TypeUtil() {}
+  private TypeUtil() {
+  }
 
   public static Schema select(Schema schema, Set<Integer> fieldIds) {
     Preconditions.checkNotNull(schema, "Schema cannot be null");

api/src/main/java/org/apache/iceberg/types/Types.java

@@ -36,7 +36,8 @@
 
 public class Types {
 
-  private Types() {}
+  private Types() {
+  }
 
   private static final ImmutableMap<String, PrimitiveType> TYPES = ImmutableMap
       .<String, PrimitiveType>builder()

api/src/test/java/org/apache/iceberg/AssertHelpers.java

@@ -24,7 +24,8 @@
 
 public class AssertHelpers {
 
-  private AssertHelpers() {}
+  private AssertHelpers() {
+  }
 
   /**
    * A convenience method to avoid a large number of @Test(expected=...) tests

api/src/test/java/org/apache/iceberg/TestHelpers.java

@@ -37,7 +37,8 @@
 
 public class TestHelpers {
 
-  private TestHelpers() {}
+  private TestHelpers() {
+  }
 
   public static <T> T assertAndUnwrap(Expression expr, Class<T> expected) {
     Assert.assertTrue("Expression should have expected type: " + expected,

arrow/src/main/java/org/apache/iceberg/arrow/ArrowSchemaUtil.java

@@ -42,7 +42,8 @@ public class ArrowSchemaUtil {
   private static final String ORIGINAL_TYPE = "originalType";
   private static final String MAP_TYPE = "mapType";
 
-  private ArrowSchemaUtil() { }
+  private ArrowSchemaUtil() {
+  }
 
   /**
    * Convert Iceberg schema to Arrow Schema.

common/src/main/java/org/apache/iceberg/common/DynClasses.java

@@ -25,7 +25,8 @@
 
 public class DynClasses {
 
-  private DynClasses() {}
+  private DynClasses() {
+  }
 
   public static Builder builder() {
     return new Builder();

common/src/main/java/org/apache/iceberg/common/DynConstructors.java

@@ -35,7 +35,8 @@
  */
 public class DynConstructors {
 
-  private DynConstructors() {}
+  private DynConstructors() {
+  }
 
   public static class Ctor<C> extends DynMethods.UnboundMethod {
     private final Constructor<C> ctor;

common/src/main/java/org/apache/iceberg/common/DynFields.java

@@ -34,7 +34,8 @@
 
 public class DynFields {
 
-  private DynFields() {}
+  private DynFields() {
+  }
 
   /**
    * Convenience wrapper class around {@link java.lang.reflect.Field}.

common/src/main/java/org/apache/iceberg/common/DynMethods.java

@@ -34,7 +34,8 @@
  */
 public class DynMethods {
 
-  private DynMethods() {}
+  private DynMethods() {
+  }
 
   /**
    * Convenience wrapper class around {@link java.lang.reflect.Method}.

core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java

@@ -51,7 +51,8 @@ public abstract class BaseMetastoreTableOperations implements TableOperations {
   private boolean shouldRefresh = true;
   private int version = -1;
 
-  protected BaseMetastoreTableOperations() { }
+  protected BaseMetastoreTableOperations() {
+  }
 
   @Override
   public TableMetadata current() {

core/src/main/java/org/apache/iceberg/DataFiles.java

@@ -35,7 +35,8 @@
 
 public class DataFiles {
 
-  private DataFiles() {}
+  private DataFiles() {
+  }
 
   static PartitionData newPartitionData(PartitionSpec spec) {
     return new PartitionData(spec.partitionType());

core/src/main/java/org/apache/iceberg/InheritableMetadataFactory.java

@@ -25,7 +25,8 @@ class InheritableMetadataFactory {
 
   private static final InheritableMetadata EMPTY = new EmptyInheritableMetadata();
 
-  private InheritableMetadataFactory() {}
+  private InheritableMetadataFactory() {
+  }
 
   static InheritableMetadata empty() {
     return EMPTY;
@@ -84,7 +85,8 @@ public <F extends ContentFile<F>> ManifestEntry<F> apply(ManifestEntry<F> manife
 
   static class EmptyInheritableMetadata implements InheritableMetadata {
 
-    private EmptyInheritableMetadata() {}
+    private EmptyInheritableMetadata() {
+    }
 
     @Override
     public <F extends ContentFile<F>> ManifestEntry<F> apply(ManifestEntry<F> manifestEntry) {

core/src/main/java/org/apache/iceberg/LocationProviders.java

@@ -32,7 +32,8 @@
 
 public class LocationProviders {
 
-  private LocationProviders() {}
+  private LocationProviders() {
+  }
 
   public static LocationProvider locationsFor(String location, Map<String, String> properties) {
     if (PropertyUtil.propertyAsBoolean(properties,

core/src/main/java/org/apache/iceberg/MetricsConfig.java

@@ -36,7 +36,8 @@ public class MetricsConfig implements Serializable {
   private Map<String, MetricsMode> columnModes = Maps.newHashMap();
   private MetricsMode defaultMode;
 
-  private MetricsConfig() {}
+  private MetricsConfig() {
+  }
 
   public static MetricsConfig getDefault() {
     MetricsConfig spec = new MetricsConfig();

core/src/main/java/org/apache/iceberg/MetricsModes.java

@@ -35,7 +35,8 @@ public class MetricsModes {
 
   private static final Pattern TRUNCATE = Pattern.compile("truncate\\((\\d+)\\)");
 
-  private MetricsModes() {}
+  private MetricsModes() {
+  }
 
   public static MetricsMode fromString(String mode) {
     if ("none".equalsIgnoreCase(mode)) {
@@ -55,7 +56,8 @@ public static MetricsMode fromString(String mode) {
     throw new IllegalArgumentException("Invalid metrics mode: " + mode);
   }
 
-  public interface MetricsMode extends Serializable {}
+  public interface MetricsMode extends Serializable {
+  }
 
   /**
    * Under this mode, value_counts, null_value_counts, lower_bounds, upper_bounds are not persisted.

core/src/main/java/org/apache/iceberg/SchemaParser.java

@@ -36,7 +36,8 @@
 
 public class SchemaParser {
 
-  private SchemaParser() {}
+  private SchemaParser() {
+  }
 
   private static final String TYPE = "type";
   private static final String STRUCT = "struct";

core/src/main/java/org/apache/iceberg/SnapshotParser.java

@@ -35,7 +35,8 @@
 
 public class SnapshotParser {
 
-  private SnapshotParser() {}
+  private SnapshotParser() {
+  }
 
   private static final String SEQUENCE_NUMBER = "sequence-number";
   private static final String SNAPSHOT_ID = "snapshot-id";

core/src/main/java/org/apache/iceberg/SystemProperties.java

@@ -24,7 +24,8 @@
  */
 public class SystemProperties {
 
-  private SystemProperties() {}
+  private SystemProperties() {
+  }
 
   /**
    * Sets the size of the worker pool. The worker pool limits the number of tasks concurrently

core/src/main/java/org/apache/iceberg/TableMetadataParser.java

@@ -77,7 +77,8 @@ public static Codec fromFileName(String fileName) {
     }
   }
 
-  private TableMetadataParser() {}
+  private TableMetadataParser() {
+  }
 
   // visible for testing
   static final String FORMAT_VERSION = "format-version";

core/src/main/java/org/apache/iceberg/TableProperties.java

@@ -21,7 +21,8 @@
 
 public class TableProperties {
 
-  private TableProperties() {}
+  private TableProperties() {
+  }
 
   public static final String COMMIT_NUM_RETRIES = "commit.retry.num-retries";
   public static final int COMMIT_NUM_RETRIES_DEFAULT = 4;

core/src/main/java/org/apache/iceberg/Transactions.java

@@ -23,7 +23,8 @@
 import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
 
 public final class Transactions {
-  private Transactions() {}
+  private Transactions() {
+  }
 
   public static Transaction createOrReplaceTableTransaction(
       String tableName, TableOperations ops, TableMetadata start) {

core/src/main/java/org/apache/iceberg/avro/AvroSchemaUtil.java

@@ -38,7 +38,8 @@
 
 public class AvroSchemaUtil {
 
-  private AvroSchemaUtil() {}
+  private AvroSchemaUtil() {
+  }
 
   // Original Iceberg field name corresponding to a sanitized Avro name
   public static final String ICEBERG_FIELD_NAME_PROP = "iceberg-field-name";

core/src/main/java/org/apache/iceberg/data/avro/DecoderResolver.java

@@ -39,7 +39,8 @@ public class DecoderResolver {
   private static final ThreadLocal<Map<Schema, Map<Schema, ResolvingDecoder>>> DECODER_CACHES =
       ThreadLocal.withInitial(() -> new MapMaker().weakKeys().makeMap());
 
-  private DecoderResolver() {}
+  private DecoderResolver() {
+  }
 
   public static <T> T resolveAndRead(
       Decoder decoder, Schema readSchema, Schema fileSchema, ValueReader<T> reader, T reuse) throws IOException {

core/src/main/java/org/apache/iceberg/encryption/EncryptedFiles.java

@@ -53,5 +53,6 @@ public static EncryptedOutputFile encryptedOutput(OutputFile encryptedOutputFile
     return encryptedOutput(encryptedOutputFile, BaseEncryptionKeyMetadata.fromByteArray(keyMetadata));
   }
 
-  private EncryptedFiles() {}
+  private EncryptedFiles() {
+  }
 }

core/src/main/java/org/apache/iceberg/encryption/EncryptionKeyMetadatas.java

@@ -31,5 +31,6 @@ public static EncryptionKeyMetadata of(byte[] keyMetadata) {
     return BaseEncryptionKeyMetadata.fromByteArray(keyMetadata);
   }
 
-  private EncryptionKeyMetadatas() {}
+  private EncryptionKeyMetadatas() {
+  }
 }

core/src/main/java/org/apache/iceberg/hadoop/HadoopStreams.java

@@ -41,7 +41,8 @@
  */
 class HadoopStreams {
 
-  private HadoopStreams() {}
+  private HadoopStreams() {
+  }
 
   private static final Logger LOG = LoggerFactory.getLogger(HadoopStreams.class);
 

core/src/main/java/org/apache/iceberg/hadoop/HiddenPathFilter.java

@@ -30,7 +30,8 @@ public class HiddenPathFilter implements PathFilter {
 
   private static final HiddenPathFilter INSTANCE = new HiddenPathFilter();
 
-  private HiddenPathFilter() {}
+  private HiddenPathFilter() {
+  }
 
   public static HiddenPathFilter get() {
     return INSTANCE;

core/src/main/java/org/apache/iceberg/util/ByteBuffers.java

@@ -58,5 +58,6 @@ public static ByteBuffer copy(ByteBuffer buffer) {
     return ByteBuffer.wrap(copyArray);
   }
 
-  private ByteBuffers() {}
+  private ByteBuffers() {
+  }
 }

core/src/main/java/org/apache/iceberg/util/ExceptionUtil.java

@@ -21,7 +21,8 @@
 
 public class ExceptionUtil {
 
-  private ExceptionUtil() {}
+  private ExceptionUtil() {
+  }
 
   @SuppressWarnings("unchecked")
   static <E extends Exception> void castAndThrow(

core/src/main/java/org/apache/iceberg/util/JsonUtil.java

@@ -31,7 +31,8 @@
 
 public class JsonUtil {
 
-  private JsonUtil() {}
+  private JsonUtil() {
+  }
 
   private static final JsonFactory FACTORY = new JsonFactory();
   private static final ObjectMapper MAPPER = new ObjectMapper(FACTORY);

core/src/main/java/org/apache/iceberg/util/PropertyUtil.java

@@ -23,7 +23,8 @@
 
 public class PropertyUtil {
 
-  private PropertyUtil() {}
+  private PropertyUtil() {
+  }
 
   public static boolean propertyAsBoolean(Map<String, String> properties,
                                           String property, boolean defaultValue) {