AWS: Prevent excessive creation of auth sessions in S3V4RestSignerClient #13215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adutra
force-pushed
the
signer-auth-manager-static
branch
2 times, most recently
from
d6e7493 to
f72358f
Compare
nastra
reviewed
Jun 2, 2025
| } | ||
| } | ||
| } | ||
|
|
||
| return authSession; | ||
| } | ||
|
|
||
| static { |
There was a problem hiding this comment.
can we move this further to the top?
|
Heads up: I need more changes to make this work properly. |
adutra
force-pushed
the
signer-auth-manager-static
branch
from
f72358f to
58342c0
Compare
Done, this is now ready for review. FYI we needed to implement session caching for sessions obtained via the |
adutra
commented
Jun 2, 2025
| sessionCache = newSessionCache(name, properties); | ||
| } | ||
|
|
||
| if (config.token() != null) { |
There was a problem hiding this comment.
This is basically the same logic as in catalogSession(), but with caching enabled.
nastra
reviewed
Jun 3, 2025
| @VisibleForTesting | ||
| AuthSession authSession() { | ||
| if (null == authSession) { | ||
| private AuthManager authManager() { |
There was a problem hiding this comment.
could you please move the authManager() method just below authSession() as it's causing a diff that adds visual overhead during review
adutra
added a commit
to adutra/iceberg-auth-manager
that referenced
this pull request
Jun 3, 2025
See apache/iceberg#13215 for context. In Iceberg 1.9.0, "standalone" sessions created by the S3 request signer client weren't cached, and an AuthManager was created for each signer instance. This is a performance degradation compared to the situation pre-AuthManager, where sessions were cached by the signer itself, and the cache was a static field. In Iceberg 1.10.0, this should be fixed, but also requires this AuthManager to implement proper caching of sessions created by the signer client.
adutra
added a commit
to adutra/iceberg-auth-manager
that referenced
this pull request
Jun 3, 2025
See apache/iceberg#13215 for context. In Iceberg 1.9.0, "standalone" sessions created by the S3 request signer client weren't cached, and an AuthManager was created for each signer instance. This is a performance degradation compared to the situation pre-AuthManager, where sessions were cached by the signer itself, and the cache was a static field. In Iceberg 1.10.0, this should be fixed, but also requires this AuthManager to implement proper caching of sessions created by the signer client.
adutra
added a commit
to dremio/iceberg-auth-manager
that referenced
this pull request
Jun 3, 2025
See apache/iceberg#13215 for context. In Iceberg 1.9.0, "standalone" sessions created by the S3 request signer client weren't cached, and an AuthManager was created for each signer instance. This is a performance degradation compared to the situation pre-AuthManager, where sessions were cached by the signer itself, and the cache was a static field. In Iceberg 1.10.0, this should be fixed, but also requires this AuthManager to implement proper caching of sessions created by the signer client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an oversight in
S3V4RestSignerClientintroduced by the switch to the AuthManager API: the session cache was previously a static field, but became an instance field. As a result, too many token fetches are being observed when using request signing.