Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark 3.4: Migrate SparkRowLevelOperationsTestBase related tests to JUnit 5 #12656

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

tomtongue
Copy link
Contributor

@tomtongue tomtongue commented Mar 26, 2025

Migrate Spark 3.4 tests based on JUnit 4 to Junit5 with AssertJ style. This is related to #7160

This PR migrates SparkRowLevelOperationsTestBase related tests in Spark 3.4 into JUnit 5 with AssertJ. The following classes are included in this PR:

  • SparkRowLevelOperationsTestBase
    • TestDelete, and TestCopyOnWriteDelete/TestMergeOnReadDelete
    • TestMerge, and TestCopyOnWriteMerge/TestMergeOnReadMerge
    • TestUpdate, and TestCopyOnWriteUpdate/TestMergeOnReadUpdate

@tomtongue
Copy link
Contributor Author

tomtongue commented Mar 27, 2025

@nastra When you have a chance, could you review this?
I'm trying to migrate the ExtensionsBase related tests to Spark 3.5 in this PR (and thanks for replacing the test base!)

Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @tomtongue

@nastra nastra merged commit 25409c6 into apache:main Mar 27, 2025
27 checks passed
@tomtongue
Copy link
Contributor Author

@nastra Thanks so much!

@tomtongue tomtongue deleted the spark3.4-rowlevel-testbase branch March 27, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants