Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flink: Support create table like and source watermark for flink sql to 1.18,1.19 #12643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

swapna267
Copy link
Contributor

Backporting changes in following PR's to Flink-1.18 and Flink-1.19

#12199
#12191

@github-actions github-actions bot added the flink label Mar 25, 2025
@pvary
Copy link
Contributor

pvary commented Mar 25, 2025

@swapna267: is this a clean backport?
For future backports, please create one backport PR for every PR on the main. People maintaining internal versions of Iceberg might want to have one set of changes on their branch, and might opt out from cherry picking another change. If we combine backports, we make their life harder.

@swapna267
Copy link
Contributor Author

Oh ok. Was not aware of that. I merged 2 PR's into one, while backporting.

Will close this and create separate backport PR's corresponding to individual PR's. Thanks.

@swapna267
Copy link
Contributor Author

As both PR's , 1.20 PR's #12199
#12191
are already merged into main, will it still be helpful to have separate backport PR's or can we have merged into one ?

@pvary
Copy link
Contributor

pvary commented Mar 28, 2025

I still prefer 1 by 1 backports.

@swapna267
Copy link
Contributor Author

Sure.
Created new PR , #12679 for backporting #12199 . Once merged, will create next one, as there are overlapping changes.

@pvary
Copy link
Contributor

pvary commented Mar 29, 2025

Thanks for your understanding @swapna267 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants